Unify the way alerts and users are handled on the DB side

token_bot/persistant_database/alert_schema.py

@@ -19,7 +19,7 @@ class Alert:
         self.region: Region = region
         self.price: int = price
         self._loaded: bool = False
-        self._users: List[pdb.User] = []
+        self.users: List[pdb.User] = []
 
     @classmethod
     def from_item(cls, primary_key: int, sort_key: str, users: List[int]) -> 'Alert':
@@ -82,18 +82,15 @@ class Alert:
             await self.get(table, consistent=consistent)
 
     async def _append_user(self, table: Table, user: pdb.User) -> None:
-        self._users.append(user)
+        self.users.append(user)
         await self.put(table)
 
     async def _remove_user(self, table: Table, user: pdb.User) -> None:
-        update_expression = F("users").delete({user.user_id})
-        await table.update_item(
-            key=self.key,
-            update_expression=update_expression
-        )
+        self.users.remove(user)
+        await self.put(table)
 
     async def put(self, table: Table) -> None:
-        user_ids = [str(user.user_id) for user in self._users]
+        user_ids = [str(user.user_id) for user in self.users]
         await table.put_item(
             item={
                 self.primary_key_name: self.primary_key,
@@ -110,23 +107,23 @@ class Alert:
             )
         except ItemNotFound:
             return False
-        self._users = [pdb.User(int(user_id)) for user_id in response['users']]
+        self.users = [pdb.User(int(user_id)) for user_id in response['users']]
         self._loaded = True
         return True
 
     async def get_users(self, table: Table, consistent: bool = False) -> List[pdb.User]:
         await self._lazy_load(table, consistent=consistent)
 
-        return self._users
+        return self.users
 
     async def add_user(self, table: Table, user: pdb.User, consistent: bool = False) -> None:
         await self._lazy_load(table, consistent=consistent)
 
-        if user not in self._users:
+        if user not in self.users:
             await self._append_user(table=table, user=user)
 
     async def remove_user(self, table: Table, user: pdb.User, consistent: bool = True) -> None:
         await self._lazy_load(table, consistent=consistent)
 
-        if user in self._users:
+        if user in self.users:
             await self._remove_user(table=table, user=user)